Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: content/renderer/render_widget.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_WIDGET_H_ 5 #ifndef CONTENT_RENDERER_RENDER_WIDGET_H_
6 #define CONTENT_RENDERER_RENDER_WIDGET_H_ 6 #define CONTENT_RENDERER_RENDER_WIDGET_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 void ObserveGestureEventAndResult(const blink::WebGestureEvent& gesture_event, 256 void ObserveGestureEventAndResult(const blink::WebGestureEvent& gesture_event,
257 const gfx::Vector2dF& unused_delta, 257 const gfx::Vector2dF& unused_delta,
258 bool event_processed) override; 258 bool event_processed) override;
259 259
260 void OnDidHandleKeyEvent() override; 260 void OnDidHandleKeyEvent() override;
261 void OnDidOverscroll(const ui::DidOverscrollParams& params) override; 261 void OnDidOverscroll(const ui::DidOverscrollParams& params) override;
262 void OnInputEventAck(std::unique_ptr<InputEventAck> input_event_ack) override; 262 void OnInputEventAck(std::unique_ptr<InputEventAck> input_event_ack) override;
263 void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type, 263 void NotifyInputEventHandled(blink::WebInputEvent::Type handled_type,
264 InputEventAckState ack_result) override; 264 InputEventAckState ack_result) override;
265 void SetInputHandler(RenderWidgetInputHandler* input_handler) override; 265 void SetInputHandler(RenderWidgetInputHandler* input_handler) override;
266 void UpdateTextInputState(ShowIme show_ime, 266 void ShowVirtualKeyboard() override;
267 ChangeSource change_source) override; 267 void UpdateTextInputState() override;
268 bool WillHandleGestureEvent(const blink::WebGestureEvent& event) override; 268 bool WillHandleGestureEvent(const blink::WebGestureEvent& event) override;
269 bool WillHandleMouseEvent(const blink::WebMouseEvent& event) override; 269 bool WillHandleMouseEvent(const blink::WebMouseEvent& event) override;
270 270
271 // RenderWidgetScreenMetricsDelegate 271 // RenderWidgetScreenMetricsDelegate
272 void Redraw() override; 272 void Redraw() override;
273 void Resize(const ResizeParams& resize_params) override; 273 void Resize(const ResizeParams& resize_params) override;
274 void SetScreenMetricsEmulationParameters( 274 void SetScreenMetricsEmulationParameters(
275 bool enabled, 275 bool enabled,
276 const blink::WebDeviceEmulationParams& params) override; 276 const blink::WebDeviceEmulationParams& params) override;
277 void SetScreenRects(const gfx::Rect& view_screen_rect, 277 void SetScreenRects(const gfx::Rect& view_screen_rect,
(...skipping 12 matching lines...) Expand all
290 blink::WebTextDirection hint) override; 290 blink::WebTextDirection hint) override;
291 void setWindowRect(const blink::WebRect&) override; 291 void setWindowRect(const blink::WebRect&) override;
292 blink::WebScreenInfo screenInfo() override; 292 blink::WebScreenInfo screenInfo() override;
293 void resetInputMethod() override; 293 void resetInputMethod() override;
294 void didHandleGestureEvent(const blink::WebGestureEvent& event, 294 void didHandleGestureEvent(const blink::WebGestureEvent& event,
295 bool event_cancelled) override; 295 bool event_cancelled) override;
296 void didOverscroll(const blink::WebFloatSize& overscrollDelta, 296 void didOverscroll(const blink::WebFloatSize& overscrollDelta,
297 const blink::WebFloatSize& accumulatedOverscroll, 297 const blink::WebFloatSize& accumulatedOverscroll,
298 const blink::WebFloatPoint& position, 298 const blink::WebFloatPoint& position,
299 const blink::WebFloatSize& velocity) override; 299 const blink::WebFloatSize& velocity) override;
300 void showImeIfNeeded() override; 300 void showVirtualKeyboard() override;
301 void convertViewportToWindow(blink::WebRect* rect) override; 301 void convertViewportToWindow(blink::WebRect* rect) override;
302 void convertWindowToViewport(blink::WebFloatRect* rect) override; 302 void convertWindowToViewport(blink::WebFloatRect* rect) override;
303 bool requestPointerLock() override; 303 bool requestPointerLock() override;
304 void requestPointerUnlock() override; 304 void requestPointerUnlock() override;
305 bool isPointerLocked() override; 305 bool isPointerLocked() override;
306 void startDragging(blink::WebReferrerPolicy policy, 306 void startDragging(blink::WebReferrerPolicy policy,
307 const blink::WebDragData& data, 307 const blink::WebDragData& data,
308 blink::WebDragOperationsMask mask, 308 blink::WebDragOperationsMask mask,
309 const blink::WebImage& image, 309 const blink::WebImage& image,
310 const blink::WebPoint& imageOffset) override; 310 const blink::WebPoint& imageOffset) override;
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 // be left in a state waiting for something that never comes. And if it 803 // be left in a state waiting for something that never comes. And if it
804 // never comes then it may later determine this is a hung renderer; so 804 // never comes then it may later determine this is a hung renderer; so
805 // instead fail right away. 805 // instead fail right away.
806 void SendOrCrash(IPC::Message* msg); 806 void SendOrCrash(IPC::Message* msg);
807 807
808 // Determines whether or not RenderWidget should process IME events from the 808 // Determines whether or not RenderWidget should process IME events from the
809 // browser. It always returns true unless there is no WebFrameWidget to 809 // browser. It always returns true unless there is no WebFrameWidget to
810 // handle the event, or there is no page focus. 810 // handle the event, or there is no page focus.
811 bool ShouldHandleImeEvents() const; 811 bool ShouldHandleImeEvents() const;
812 812
813 void UpdateTextInputStateInternal(bool show_virtual_keyboard,
814 bool reply_to_request);
815
813 // Indicates whether this widget has focus. 816 // Indicates whether this widget has focus.
814 bool has_focus_; 817 bool has_focus_;
815 818
816 // A callback into the creator/opener of this widget, to be executed when 819 // A callback into the creator/opener of this widget, to be executed when
817 // WebWidgetClient::show() occurs. 820 // WebWidgetClient::show() occurs.
818 ShowCallback show_callback_; 821 ShowCallback show_callback_;
819 822
820 #if defined(OS_MACOSX) 823 #if defined(OS_MACOSX)
821 // Responds to IPCs from TextInputClientMac regarding getting string at given 824 // Responds to IPCs from TextInputClientMac regarding getting string at given
822 // position or range as well as finding character index at a given position. 825 // position or range as well as finding character index at a given position.
(...skipping 12 matching lines...) Expand all
835 // being handled. If the current event results in starting a drag/drop 838 // being handled. If the current event results in starting a drag/drop
836 // session, this info is sent to the browser along with other drag/drop info. 839 // session, this info is sent to the browser along with other drag/drop info.
837 DragEventSourceInfo possible_drag_event_info_; 840 DragEventSourceInfo possible_drag_event_info_;
838 841
839 DISALLOW_COPY_AND_ASSIGN(RenderWidget); 842 DISALLOW_COPY_AND_ASSIGN(RenderWidget);
840 }; 843 };
841 844
842 } // namespace content 845 } // namespace content
843 846
844 #endif // CONTENT_RENDERER_RENDER_WIDGET_H_ 847 #endif // CONTENT_RENDERER_RENDER_WIDGET_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698