content/renderer/service_worker/embedded_worker_dispatcher.cc - Issue 2596173002: Use explicit WebString <-> string conversion methods for workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 2596173002: Use explicit WebString <-> string conversion methods for workers (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/embedded_worker_dispatcher.cc

diff --git a/content/renderer/service_worker/embedded_worker_dispatcher.cc b/content/renderer/service_worker/embedded_worker_dispatcher.cc

index bf046f2ee23ceec3a7230921a88171dda91f6232..25da801686b582958553ad7b155a2b8874fe7673 100644

--- a/content/renderer/service_worker/embedded_worker_dispatcher.cc

+++ b/content/renderer/service_worker/embedded_worker_dispatcher.cc

@@ -138,7 +138,8 @@ EmbeddedWorkerDispatcher::StartWorkerContext(

blink::WebEmbeddedWorkerStartData start_data;

start_data.scriptURL = params.script_url;

- start_data.userAgent = base::UTF8ToUTF16(GetContentClient()->GetUserAgent());

+ start_data.userAgent =

+ blink::WebString::fromUTF8(GetContentClient()->GetUserAgent());

start_data.waitForDebuggerMode =

params.wait_for_debugger

? blink::WebEmbeddedWorkerStartData::WaitForDebugger