chrome/renderer/net/net_error_helper.cc - Issue 259613003: Fix auto-reload histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/net/net_error_helper.cc

Issue 259613003: Fix auto-reload histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Rework state machine a bit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/net/net_error_helper.cc

diff --git a/chrome/renderer/net/net_error_helper.cc b/chrome/renderer/net/net_error_helper.cc

index 5ef563f7354e61d1f00b82d0dd07212da09f399d..0cc35314d6b5a81b4a587c3bba4830e3182eee42 100644

--- a/chrome/renderer/net/net_error_helper.cc

+++ b/chrome/renderer/net/net_error_helper.cc

@@ -114,7 +114,8 @@ void NetErrorHelper::DidStartProvisionalLoad() {

void NetErrorHelper::DidCommitProvisionalLoad(bool is_new_navigation) {

blink::WebFrame* frame = render_frame()->GetWebFrame();

- core_.OnCommitLoad(GetFrameType(frame));

+ GURL url(frame->document().url());

+ core_.OnCommitLoad(GetFrameType(frame), url);

Randy Smith (Not in Mondays) 2014/04/30 18:22:16 I don't personally care, but is there a reason to

Elly Fong-Jones 2014/05/01 18:33:03 Done.

}

void NetErrorHelper::DidFinishLoad() {