Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 259613002: Fix a TSAN failure of QUIC's EndToEndTest where the value of (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)
Modified:
6 years, 8 months ago
Reviewers:
oshima, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, oshima
Visibility:
Public.

Description

Fix a TSAN failure of QUIC's EndToEndTest where the value of QuicConnectionStats were being checked while the server thread was modifying them. Merge internal change: 65521936 R=rch@chromium.org BUG=366594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/tools/quic/end_to_end_test.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ramant (doing other things)
6 years, 8 months ago (2014-04-24 17:55:50 UTC) #1
Ryan Hamilton
lgtm
6 years, 8 months ago (2014-04-24 17:58:07 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 8 months ago (2014-04-24 17:58:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/259613002/1
6 years, 8 months ago (2014-04-24 21:50:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:49:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 23:49:30 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-24 23:52:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/259613002/1
6 years, 8 months ago (2014-04-24 23:53:16 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 00:56:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-25 00:56:59 UTC) #10
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-25 01:01:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/259613002/1
6 years, 8 months ago (2014-04-25 01:03:13 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 03:10:17 UTC) #13
Message was sent while issue was closed.
Change committed as 266111

Powered by Google App Engine
This is Rietveld 408576698