Retain tray bubble's rounded corners when the bubble animates out

ui/compositor/layer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 38 matching lines @@
       parent_(NULL),
       visible_(true),
       force_render_surface_(false),
       fills_bounds_opaquely_(true),
       layer_updated_externally_(false),
       background_blur_radius_(0),
       layer_saturation_(0.0f),
       layer_brightness_(0.0f),
       layer_grayscale_(0.0f),
       layer_inverted_(false),
-      layer_mask_(NULL),
       layer_mask_back_link_(NULL),
       zoom_(1),
       zoom_inset_(0),
       delegate_(NULL),
       cc_layer_(NULL),
       scale_content_(true),
       device_scale_factor_(1.0f) {
+  layer_mask_.reset(NULL);

[Jun Mukai, 2013/10/04 01:39:36]

nit: just reset(), NULL is not necessary

[piman, 2013/10/04 03:44:39]

Just remove. The default scoped_ptr constructor does the right thing.

[michaelpg, 2013/10/04 05:56:41]

Done.

   CreateWebLayer();
 }
 
 Layer::Layer(LayerType type)
     : type_(type),
       compositor_(NULL),
       parent_(NULL),
       visible_(true),
       force_render_surface_(false),
       fills_bounds_opaquely_(true),
       layer_updated_externally_(false),
       background_blur_radius_(0),
       layer_saturation_(0.0f),
       layer_brightness_(0.0f),
       layer_grayscale_(0.0f),
       layer_inverted_(false),
-      layer_mask_(NULL),
       layer_mask_back_link_(NULL),
       zoom_(1),
       zoom_inset_(0),
       delegate_(NULL),
       cc_layer_(NULL),
       scale_content_(true),
       device_scale_factor_(1.0f) {
+  layer_mask_.reset(NULL);

[Jun Mukai, 2013/10/04 01:39:36]

ditto

[michaelpg, 2013/10/04 05:56:41]

Removed

   CreateWebLayer();
 }
 
 Layer::~Layer() {
   // Destroying the animator may cause observers to use the layer (and
   // indirectly the WebLayer). Destroy the animator first so that the WebLayer
   // is still around.
   if (animator_.get())
     animator_->SetDelegate(NULL);
   animator_ = NULL;
   if (compositor_)
     compositor_->SetRootLayer(NULL);
   if (parent_)
     parent_->Remove(this);
-  if (layer_mask_)
+  if (layer_mask_.get())
     SetMaskLayer(NULL);
   if (layer_mask_back_link_)

[Jun Mukai, 2013/10/04 01:39:36]

this is weird, if the layer_mask_ is owned by the layer, layer_mask_ cannot be
released by someone else. It means that back_link_ isn't necessary at all.

[piman, 2013/10/04 03:44:39]

Agreed. Please remove.

[michaelpg, 2013/10/04 05:56:41]

Done.

     layer_mask_back_link_->SetMaskLayer(NULL);
   for (size_t i = 0; i < children_.size(); ++i)
     children_[i]->parent_ = NULL;
   cc_layer_->RemoveLayerAnimationEventObserver(this);
   cc_layer_->RemoveFromParent();
 }
 
 Compositor* Layer::GetCompositor() {
   return GetRoot(this)->compositor_;
 }
@@ skipping 160 matching lines @@
 void Layer::SetLayerInverted(bool inverted) {
   layer_inverted_ = inverted;
   SetLayerFilters();
 }
 
 void Layer::SetMaskLayer(Layer* layer_mask) {
   // The provided mask should not have a layer mask itself.
   DCHECK(!layer_mask ||
          (!layer_mask->layer_mask_layer() &&
           layer_mask->children().empty() &&
           !layer_mask->layer_mask_back_link_));

[michaelpg, 2013/10/04 05:56:41]

Removing this debug check (because we remove the member) means we no longer
ensure that the layer mask is not already a layer mask for some other layer. But
since SetMaskLayer takes ownership I suppose this shouldn't be a concern
anymore.

   DCHECK(!layer_mask_back_link_);
   if (layer_mask_ == layer_mask)
     return;
   // We need to de-reference the currently linked object so that no problem
   // arises if the mask layer gets deleted before this object.
-  if (layer_mask_)
+  if (layer_mask_.get())
     layer_mask_->layer_mask_back_link_ = NULL;
-  layer_mask_ = layer_mask;
+  layer_mask_.reset(layer_mask);
   cc_layer_->SetMaskLayer(
       layer_mask ? layer_mask->cc_layer() : NULL);
   // We need to reference the linked object so that it can properly break the
   // link to us when it gets deleted.
   if (layer_mask) {
     layer_mask->layer_mask_back_link_ = this;
     layer_mask->OnDeviceScaleFactorChanged(device_scale_factor_);
   }
 }
 
@@ skipping 309 matching lines @@
   gfx::Transform transform = this->transform();
   device_scale_factor_ = device_scale_factor;
   RecomputeCCTransformFromTransform(transform);
   RecomputeDrawsContentAndUVRect();
   RecomputePosition();
   SchedulePaint(gfx::Rect(bounds_.size()));
   if (delegate_)
     delegate_->OnDeviceScaleFactorChanged(device_scale_factor);
   for (size_t i = 0; i < children_.size(); ++i)
     children_[i]->OnDeviceScaleFactorChanged(device_scale_factor);
-  if (layer_mask_)
+  if (layer_mask_.get())
     layer_mask_->OnDeviceScaleFactorChanged(device_scale_factor);
 }
 
 void Layer::RequestCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request) {
   cc_layer_->RequestCopyOfOutput(request.Pass());
 }
 
 void Layer::PaintContents(SkCanvas* sk_canvas,
                           gfx::Rect clip,
                           gfx::RectF* opaque) {
@@ skipping 335 matching lines @@
   cc_layer_->SetBounds(ConvertSizeToPixel(this, size));
 }
 
 void Layer::RecomputePosition() {
   cc_layer_->SetPosition(gfx::ScalePoint(
         gfx::PointF(bounds_.x(), bounds_.y()),
         device_scale_factor_));
 }
 
 }  // namespace ui