Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2596083003: Use standardized accelerator-to-shortcut code for new backspace shortcut UI. (Closed)

Created:
4 years ago by Peter Kasting
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Use standardized accelerator-to-shortcut code for new backspace shortcut UI. This changes the left and right arrow symbols into text (e.g. "left arrow"), reducing ambiguity. It also promotes cmd-[ over cmd-left on Mac. BUG=637547 TEST=On a new profile, have a page in your "back" session history, then hit backspace twice while outside a textfield to trigger the "Use alt-left to go back" UI. It should say "Left arrow" instead of "<-". Review-Url: https://codereview.chromium.org/2540523003 Cr-Commit-Position: refs/heads/master@{#439747} (cherry picked from commit 00d3a368e97975b82f4dc4f483f6e8c6e85331c0) Committed: https://chromium.googlesource.com/chromium/src/+/7f18e530baf0f121b54634b39ddec536715a8a79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/new_back_shortcut_bubble.cc View 2 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Kasting
4 years ago (2016-12-22 00:48:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f18e530baf0f121b54634b39ddec536715a8a79.

Powered by Google App Engine
This is Rietveld 408576698