Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 259603002: Add touch and basic longpress typing tests for the IME keyboard. (Closed)

Created:
6 years, 8 months ago by rsadam
Modified:
6 years, 6 months ago
Reviewers:
bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Add touch and basic longpress typing tests for the IME keyboard. To be landed after: https://codereview.chromium.org/247883002/ BUG=353857

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -9 lines) Patch
M chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js View 1 5 chunks +106 lines, -6 lines 0 comments Download
M chrome/test/data/chromeos/virtual_keyboard/inputview/typing_test.js View 1 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rsadam
This is a followup patch to the test framework. PTAL Biao! https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right): ...
6 years, 8 months ago (2014-04-24 17:45:04 UTC) #1
bshe
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right): https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js#newcode77 chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:77: */ Assume this will be used when add upper ...
6 years, 8 months ago (2014-04-24 18:36:25 UTC) #2
rsadam
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js (right): https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js#newcode77 chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:77: */ On 2014/04/24 18:36:25, bshe wrote: > Assume this ...
6 years, 8 months ago (2014-04-24 21:23:25 UTC) #3
bshe
6 years, 7 months ago (2014-04-29 16:02:05 UTC) #4
On 2014/04/24 21:23:25, rsadam wrote:
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> File chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js
(right):
> 
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:77: */
> On 2014/04/24 18:36:25, bshe wrote:
> > Assume this will be used when add upper case tests? If so, could you add
this
> > function in that CL?
> 
> Done.
> 
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:154: *
@param
> {Object} The object to check.
> On 2014/04/24 18:36:25, bshe wrote:
> > nit: document return value
> 
> Done.
> 
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> chrome/test/data/chromeos/virtual_keyboard/inputview/test_base.js:212:
> generateTouchEvent(key, 'touchend', true, true)
> On 2014/04/24 18:36:25, bshe wrote:
> > should the touchend dispatched by candidate?
> 
> I believe the W3 spec is for the target to be same the same, otherwise it
> interprets it as a second finger.
> 
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> File chrome/test/data/chromeos/virtual_keyboard/inputview/typing_test.js
> (right):
> 
>
https://codereview.chromium.org/259603002/diff/1/chrome/test/data/chromeos/vi...
> chrome/test/data/chromeos/virtual_keyboard/inputview/typing_test.js:11: //
Mouse
> events.
> On 2014/04/24 18:36:25, bshe wrote:
> > We probably dont need to test the same case 5 times? Perhaps just test l and
p
> > (e and a for long press) is enough?
> 
> Done.

lgtm

Powered by Google App Engine
This is Rietveld 408576698