Issue 2595973002: Stop calling std::isfinite(double) and then casting to float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2595973002: Stop calling std::isfinite(double) and then casting to float (Closed)

Created:
4 years ago by ccameron

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, Justin Novosad, haraken, Rik, blink-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop calling std::isfinite(double) and then casting to float BUG=675123

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -21 lines)			Patch
	M	third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp	View		17 chunks	+38 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ccameron

Description was changed from ========== Fix ubsan BUG= ========== to ========== Stop calling std::isfinite(double) and ...

4 years ago (2016-12-21 19:26:00 UTC) #1

ccameron

4 years ago (2016-12-21 19:26:00 UTC) #2

Description was changed from

==========
Fix ubsan

BUG=
==========

to

==========
Stop calling std::isfinite(double) and then casting to float

BUG=675123
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages