chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java - Issue 2595933002: Change assert in RecentTabsPage.destroy()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

Issue 2595933002: Change assert in RecentTabsPage.destroy() (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

index 8b16c18b0537567e74a368c5964f980f19065f76..2ed861682524af6172696b8f82fc7dfa314f6d63 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java

@@ -170,7 +170,7 @@ public class RecentTabsPage

@Override

public void destroy() {

- assert getView().getParent() == null : "Destroy called before removed from window";

+ assert !mIsAttachedToWindow : "Destroy called before removed from window";

mRecentTabsManager.destroy();

mRecentTabsManager = null;

mAdapter.notifyDataSetInvalidated();

« no previous file with comments | « no previous file | no next file » | no next file with comments »