[NTP::SectionOrder] Add a flag to choose category ranker.

chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 84b8c58326fb843db81fc490c06da7c34bb565bb..5b8efe0e6314a7eebb963ad685b69acc5c1cb81c 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -13931,7 +13931,7 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
       </message>
       <message name="IDS_DESKTOP_MEDIA_PICKER_AUDIO_SHARE" desc="Text for the checkbox on the window picker dialog, when checked, audio will be shared, otherwise just video sharing">
         Share audio
-      </message>      
+      </message>
       <message name="IDS_DESKTOP_MEDIA_PICKER_SOURCE_TYPE_SCREEN" desc="Text for the button on the window picker dialog, clicking which takes one to full screen sharing">
         Your Entire Screen
       </message>
@@ -15134,6 +15134,12 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
     </if>
 
     <if expr="is_android">
+      <message name="IDS_FLAGS_NTP_CATEGORY_RANKER_NAME" desc="Name for the flag to choose category ranker for the New Tab page." translateable="false">
+        NTP category ranker.

[noyau (Ping after 24h), 2016/12/22 14:06:52]

This flag controls the category ranker for the categories of the suggestion
service. I would avoid the use of NTP here, as NTP is only one of the surface
this data may be published onto.

[vitaliii, 2016/12/23 13:12:51]

Done.

I changed public facing bit, but left NTP prefix internally (e.g. in message
names).

[noyau (Ping after 24h), 2016/12/23 13:26:17]

I'm of the opinion that this code is not related to the NTP. It controls the
client back end, and this data may be presented on other places unrelated to the
NTP in the future. As such NTP is the wrong term to use here, and this prefix
should be removed.

IDS_FLAGS_SNIPPETS_CATEGORY_... is a better name.

[tschumann, 2016/12/23 13:46:20]

I agree with Eric (thanks for pointing it out! we tend to get blind to
NTP-related names).
Let's not use 'NTP' anymore for things which are not strictly tied to the NTP.

We deprecated the term 'SNIPPETS' though, as it's confusing with Google's idea
of a snippet. 
So IDS_FLAGS_SUGGESTIONS_CATEGORY_RANKER would be fine with me. (IMO, there's no
need for the 'name' suffix).

We should pay more attention on such names going forward.

+      </message>
+      <message name="IDS_FLAGS_NTP_CATEGORY_RANKER_DESCRIPTION" desc="Description for the flag to choose category ranker for the New Tab page." translateable="false">
+        Set category ranker to order sections on the NTP.
+      </message>
       <message name="IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME" desc="Name for the flag to enable snippets on the New Tab page." translateable="false">
         Show content snippets on the New Tab page
       </message>