Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp

Issue 2595833002: Replaced usages of WritingMode to use inline utility functions instead (Closed)
Patch Set: Rebase and fixed ::blink with just blink:: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp b/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
index 891c8ffaec02da61ba843f9ae80a0a0492fc4731..d0984f1e91905b24960f2da9fef484c028cb0b93 100644
--- a/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp
@@ -85,7 +85,7 @@ LayoutUnit SnapToLinesLayouter::computeInitialPositionAdjustment(
WritingMode writingMode = m_cueBox.style()->getWritingMode();
// 8. Vertical Growing Left: Add one to line then negate it.
- if (writingMode == RightToLeftWritingMode)
+ if (isFlippedBlocksWritingMode(writingMode))
linePosition = -(linePosition + 1);
// 9. Let position be the result of multiplying step and line offset.
@@ -93,7 +93,7 @@ LayoutUnit SnapToLinesLayouter::computeInitialPositionAdjustment(
// 10. Vertical Growing Left: Decrease position by the width of the
// bounding box of the boxes in boxes, then increase position by step.
- if (writingMode == RightToLeftWritingMode) {
+ if (isFlippedBlocksWritingMode(writingMode)) {
position -= m_cueBox.size().width();
position += step;
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698