third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2595783002: [Editing] Add null check in |DeleteSelectionCommand::removeRedundantBlocks()|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2595783002: [Editing] Add null check in |DeleteSelectionCommand::removeRedundantBlocks()| (Closed)

Patch Set: dominicc's suggestion: Use unit test instead of layout test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index 2f1bc1a12e1d5855f2fac0a965b1c7f7d27a2b54..028d0fb5d524f8d4873d2d2c038af0d6c9eab5d6 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -1022,6 +1022,7 @@ void DeleteSelectionCommand::removeRedundantBlocks(EditingState* editingState) {

Element* rootElement = rootEditableElement(*node);

while (node != rootElement) {

+ ABORT_EDITING_COMMAND_IF(!node);

if (isRemovableBlock(node)) {

if (node == m_endingPosition.anchorNode())

updatePositionForNodeRemovalPreservingChildren(m_endingPosition, *node);

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp ('k') | no next file » | no next file with comments »