Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/cert/internal/cert_issuer_source_aia.cc

Issue 2595723002: Allow CertNetFetcher to be shutdown from the network thread (Closed)
Patch Set: tweak comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/cert_net_fetcher.h ('K') | « net/cert/cert_net_fetcher.h ('k') | net/cert/internal/cert_issuer_source_aia_unittest.cc » ('j') | net/cert_net/cert_net_fetcher_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/cert_issuer_source_aia.cc
diff --git a/net/cert/internal/cert_issuer_source_aia.cc b/net/cert/internal/cert_issuer_source_aia.cc
index 589b724884554378f493a70ce68343250c5035b1..63ea777a64a7e5e05806d28348fc5b1fd293f5de 100644
--- a/net/cert/internal/cert_issuer_source_aia.cc
+++ b/net/cert/internal/cert_issuer_source_aia.cc
@@ -58,7 +58,8 @@ void AiaRequest::GetNext(ParsedCertificateList* out_certs) {
void AiaRequest::AddCertFetcherRequest(
std::unique_ptr<CertNetFetcher::Request> cert_fetcher_request) {
- DCHECK(cert_fetcher_request);
+ if (!cert_fetcher_request)
+ return;
eroman 2017/01/03 20:42:37 See comment regarding interface
estark 2017/01/05 19:08:39 Done.
cert_fetcher_requests_.push_back(std::move(cert_fetcher_request));
}
« net/cert/cert_net_fetcher.h ('K') | « net/cert/cert_net_fetcher.h ('k') | net/cert/internal/cert_issuer_source_aia_unittest.cc » ('j') | net/cert_net/cert_net_fetcher_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698