Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: net/tools/cert_verify_tool/verify_using_path_builder.cc

Issue 2595723002: Allow CertNetFetcher to be shutdown from the network thread (Closed)
Patch Set: update comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/url_request/url_request_hanging_read_job.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/cert_verify_tool/verify_using_path_builder.cc
diff --git a/net/tools/cert_verify_tool/verify_using_path_builder.cc b/net/tools/cert_verify_tool/verify_using_path_builder.cc
index adaf5fe5d81aab62aa3d1b15f25d57e62acc3d14..6c52e4ad900c8cf612e19dfc8c69d4f17c81d739 100644
--- a/net/tools/cert_verify_tool/verify_using_path_builder.cc
+++ b/net/tools/cert_verify_tool/verify_using_path_builder.cc
@@ -281,6 +281,9 @@ bool VerifyUsingPathBuilder(
// Initialize an AIA fetcher, that uses a separate thread for running the
// networking message loop.
+// TODO(estark): update this code to use the new CertNetFetcher
+// interface that takes a URLRequestContext*.
+#if 0
base::Thread::Options options(base::MessageLoop::TYPE_IO, 0);
base::Thread thread("network_thread");
CHECK(thread.StartWithOptions(options));
@@ -290,13 +293,16 @@ bool VerifyUsingPathBuilder(
CreateCertNetFetcher(url_request_context_getter.get());
net::CertIssuerSourceAia aia_cert_issuer_source(cert_net_fetcher.get());
path_builder.AddCertIssuerSource(&aia_cert_issuer_source);
+#endif
// Run the path builder.
path_builder.Run();
+#if 0
// Stop the temporary network thread..
url_request_context_getter->ShutDown();
thread.Stop();
+#endif
// TODO(crbug.com/634443): Display any errors/warnings associated with path
// building that were not part of a particular
« no previous file with comments | « net/test/url_request/url_request_hanging_read_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698