Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: net/tools/cert_verify_tool/verify_using_path_builder.cc

Issue 2595723002: Allow CertNetFetcher to be shutdown from the network thread (Closed)
Patch Set: eroman comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/cert_verify_tool/verify_using_path_builder.cc
diff --git a/net/tools/cert_verify_tool/verify_using_path_builder.cc b/net/tools/cert_verify_tool/verify_using_path_builder.cc
index adaf5fe5d81aab62aa3d1b15f25d57e62acc3d14..bd1acc1af2e4ec13fe2dd26982eae2f0c7046b7b 100644
--- a/net/tools/cert_verify_tool/verify_using_path_builder.cc
+++ b/net/tools/cert_verify_tool/verify_using_path_builder.cc
@@ -281,6 +281,9 @@ bool VerifyUsingPathBuilder(
// Initialize an AIA fetcher, that uses a separate thread for running the
// networking message loop.
+// TODO(estark): update this code to use the new CertNetFetcher
+// interface that takes a URLRequestContext*.
+#if 0
base::Thread::Options options(base::MessageLoop::TYPE_IO, 0);
base::Thread thread("network_thread");
CHECK(thread.StartWithOptions(options));
@@ -297,6 +300,7 @@ bool VerifyUsingPathBuilder(
// Stop the temporary network thread..
url_request_context_getter->ShutDown();
thread.Stop();
+#endif
// TODO(crbug.com/634443): Display any errors/warnings associated with path
// building that were not part of a particular
« net/cert_net/cert_net_fetcher_impl.cc ('K') | « net/test/url_request/url_request_hanging_read_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698