Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: net/cert/internal/cert_issuer_source_aia.h

Issue 2595723002: Allow CertNetFetcher to be shutdown from the network thread (Closed)
Patch Set: fix AIA tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/cert_issuer_source_aia.h
diff --git a/net/cert/internal/cert_issuer_source_aia.h b/net/cert/internal/cert_issuer_source_aia.h
index 878b18bbde851cf7668bf5472ef60b9d73643034..3e62c95a0857908141136a52af5b841267c886ab 100644
--- a/net/cert/internal/cert_issuer_source_aia.h
+++ b/net/cert/internal/cert_issuer_source_aia.h
@@ -16,10 +16,10 @@ class CertNetFetcher;
class NET_EXPORT CertIssuerSourceAia : public CertIssuerSource {
public:
// Creates CertIssuerSource that will use |cert_fetcher| to retrieve issuers
- // using AuthorityInfoAccess URIs. |cert_fetcher| must outlive the
- // CertIssuerSourceAia. CertIssuerSourceAia must be created and used only on
- // a single thread, which is the thread |cert_fetcher| will be operated from.
- explicit CertIssuerSourceAia(CertNetFetcher* cert_fetcher);
+ // using AuthorityInfoAccess URIs. CertIssuerSourceAia must be created and
+ // used only on a single thread, which is the thread |cert_fetcher| will be
+ // operated from.
+ explicit CertIssuerSourceAia(scoped_refptr<CertNetFetcher> cert_fetcher);
~CertIssuerSourceAia() override;
// CertIssuerSource implementation:
@@ -29,7 +29,7 @@ class NET_EXPORT CertIssuerSourceAia : public CertIssuerSource {
std::unique_ptr<Request>* out_req) override;
private:
- CertNetFetcher* cert_fetcher_;
+ scoped_refptr<CertNetFetcher> cert_fetcher_;
DISALLOW_COPY_AND_ASSIGN(CertIssuerSourceAia);
};

Powered by Google App Engine
This is Rietveld 408576698