Allow CertNetFetcher to be shutdown from the network thread

net/tools/cert_verify_tool/verify_using_path_builder.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/cert_verify_tool/verify_using_path_builder.h"
 
 #include <iostream>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 266 matching lines @@
 #if defined(USE_NSS_CERTS)
   net::CertIssuerSourceNSS cert_issuer_source_nss;
   path_builder.AddCertIssuerSource(&cert_issuer_source_nss);
 #endif
 
   // Initialize an AIA fetcher, that uses a separate thread for running the
   // networking message loop.
   base::Thread::Options options(base::MessageLoop::TYPE_IO, 0);
   base::Thread thread("network_thread");
   CHECK(thread.StartWithOptions(options));
+
   scoped_refptr<URLRequestContextGetterForAia> url_request_context_getter(
       new URLRequestContextGetterForAia(thread.task_runner()));
+  // Create a CertNetFetcher to be initialized on the network thread.
   auto cert_net_fetcher =
-      CreateCertNetFetcher(url_request_context_getter.get());
+      CreateCertNetFetcherOnCallerThread(url_request_context_getter.get());
   net::CertIssuerSourceAia aia_cert_issuer_source(cert_net_fetcher.get());

[eroman, 2017/01/03 20:42:38]

net::CertIssuerSourceAia should be updated to hold a reference to the
CertNetFetcher.

[estark, 2017/01/05 19:08:40]

Done.

   path_builder.AddCertIssuerSource(&aia_cert_issuer_source);
 
   // Run the path builder.
   path_builder.Run();
 
-  // Stop the temporary network thread..
+  // Stop the temporary network thread.
   url_request_context_getter->ShutDown();
   thread.Stop();
 
   // TODO(crbug.com/634443): Display any errors/warnings associated with path
   //                         building that were not part of a particular
   //                         PathResult.
   std::cout << "CertPathBuilder result: "
             << (result.HasValidPath() ? "SUCCESS" : "FAILURE") << "\n";
 
   for (size_t i = 0; i < result.paths.size(); ++i) {
     PrintResultPath(result.paths[i].get(), i, i == result.best_result_index);
   }
 
   // TODO(mattm): add flag to dump all paths, not just the final one?
   if (!dump_prefix_path.empty() && result.paths.size()) {
     if (!DumpParsedCertificateChain(
             dump_prefix_path.AddExtension(
                 FILE_PATH_LITERAL(".CertPathBuilder.pem")),
             result.paths[result.best_result_index]->path)) {
       return false;
     }
   }
 
   return result.HasValidPath();
 }