Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: src/log.cc

Issue 2595673002: [profiler] Do not report native function names as script names. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-events.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index f0d7a6c3a002372d4da0f0c8c7946ca532d3acbe..e303773310ad4239816ff20bb2baa215bb807f13 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1512,7 +1512,6 @@ void Logger::LogBytecodeHandlers() {
void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,
Handle<AbstractCode> code) {
- Handle<String> func_name(shared->DebugName());
if (shared->script()->IsScript()) {
Handle<Script> script(Script::cast(shared->script()));
int line_num = Script::GetLineNumber(script, shared->start_position()) + 1;
@@ -1551,11 +1550,12 @@ void Logger::LogExistingFunction(Handle<SharedFunctionInfo> shared,
#if USES_FUNCTION_DESCRIPTORS
entry_point = *FUNCTION_ENTRYPOINT_ADDRESS(entry_point);
#endif
- PROFILE(isolate_, CallbackEvent(*func_name, entry_point));
+ PROFILE(isolate_, CallbackEvent(shared->DebugName(), entry_point));
}
} else {
- PROFILE(isolate_, CodeCreateEvent(CodeEventListener::LAZY_COMPILE_TAG,
- *code, *shared, *func_name));
+ PROFILE(isolate_,
+ CodeCreateEvent(CodeEventListener::LAZY_COMPILE_TAG, *code, *shared,
+ isolate_->heap()->empty_string()));
}
}
« no previous file with comments | « src/code-events.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698