Issue 25956002: [SPDY] Remove references to obsolete SPDY versions SPDY/1 and SPDY/2.1

Issue 25956002: [SPDY] Remove references to obsolete SPDY versions SPDY/1 and SPDY/2.1 (Closed)

Created:
7 years, 2 months ago by akalin

Modified:
7 years, 2 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Remove references to obsolete SPDY versions SPDY/1 and SPDY/2.1 Remove them from NextProto and AlternateProtocol enums. Add constants for minimum/maximum/number of valid AlternateProtocol enum values and use that consistently. Take care of TODOs to use kProtoSPDYMinimumVersion instead of kProtoSPDY2 (since they're now one and the same). BUG=303957 R=rtenneti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227043

Patch Set 1 #

Patch Set 2 : Fix compile errors #

Patch Set 3 : Fix unit test #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -99 lines)			Patch
M	chrome/browser/net/http_server_properties_manager.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/net/http_server_properties_manager_unittest.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	net/http/http_response_info.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/http/http_server_properties.h	View	1	2 chunks	+16 lines, -5 lines	0 comments	Download
M	net/http/http_server_properties.cc	View		4 chunks	+19 lines, -16 lines	0 comments	Download
M	net/http/http_server_properties_impl_unittest.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	net/http/http_stream_factory.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	net/http/http_stream_factory.cc	View		6 chunks	+29 lines, -9 lines	0 comments	Download
M	net/http/http_stream_factory_impl.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	net/socket/next_proto.h	View		1 chunk	+8 lines, -12 lines	0 comments	Download
M	net/socket/ssl_client_socket.cc	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	net/spdy/buffered_spdy_framer.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session.h	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_session_pool.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	net/spdy/spdy_stream.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	net/spdy/spdy_test_util_common.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/25956002/16001

7 years, 2 months ago (2013-10-04 16:56:24 UTC) #3

akalin

7 years, 2 months ago (2013-10-04 18:40:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r227043 (presubmit successful).

Expand Messages | Collapse Messages