Remove StatementType

Remove StatementType

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/1e31cd9e5a4571e89da5796f255157e8de8bd372

[Johnni Winther, 2016-12-20 15:07:17]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-20 20:58:42]

lgtm with some fixes below

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:455: void analyzeNode(Node node, {bool
inInitializer: false}) {
nit: consider renaming this? someone may naively call this thinking it's
equivalent to calling analyze without putting much thought into it.

Some ideas:
 - analyzeUntyped
 - change the default and add analyzeTyped
 - remove this and expilcitly pass `mustHaveType: false` where this occurs.

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:704: analyzeInPromotedContext(condition,
thenPart, mustHaveType: false);
The default value is also false. Did you mean to keep this one clear and add it
in `&&` below?

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:1660: analyzeNode(link.head,
inInitializer: analyzingInitializer);
is it always the case that node-lists are used only for statements?

[Johnni Winther, 2016-12-21 09:22:16]

Description was changed from

==========
Remove StatementType
==========

to

==========
Remove StatementType

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1e31cd9e5a4571e89da5796f255157e8de8bd372
==========

[Johnni Winther, 2016-12-21 09:22:17]

Committed patchset #2 (id:20001) manually as
1e31cd9e5a4571e89da5796f255157e8de8bd372 (presubmit successful).

[Johnni Winther, 2016-12-21 09:32:43]

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:455: void analyzeNode(Node node, {bool
inInitializer: false}) {
On 2016/12/20 20:58:42, Siggi Cherem (dart-lang) wrote:
> nit: consider renaming this? someone may naively call this thinking it's
> equivalent to calling analyze without putting much thought into it.
> 
> Some ideas:
>  - analyzeUntyped
>  - change the default and add analyzeTyped
>  - remove this and expilcitly pass `mustHaveType: false` where this occurs.

Renamed to analyzeUntyped

[Johnni Winther, 2016-12-21 10:25:02]

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:704: analyzeInPromotedContext(condition,
thenPart, mustHaveType: false);
On 2016/12/20 20:58:42, Siggi Cherem (dart-lang) wrote:
> The default value is also false. Did you mean to keep this one clear and add
it
> in `&&` below?

Default value should have been `true`.

https://codereview.chromium.org/2595583002/diff/1/pkg/compiler/lib/src/typech...
pkg/compiler/lib/src/typechecker.dart:1660: analyzeNode(link.head,
inInitializer: analyzingInitializer);
On 2016/12/20 20:58:42, Siggi Cherem (dart-lang) wrote:
> is it always the case that node-lists are used only for statements?

No, but we don't need the individual types, anyway.