VM: [DBC] Fix more problems with lazy deopt.

VM: [DBC] Fix more problems with lazy deopt.

Catch entries must record a lazy deoptimization descriptor because we patch catch entries if exception reaches a frame that has a pending lazy deoptimization.

StringInterpolate instruction was recording an incorrect lazy deoptimization environment - on DBC we drop arguments from it because it is a part of the return sequence and not a part of the calling sequence like on other architectures. This means one needs to pass correct argument count down to RecordAfterCall(Helper). StringInterpolate however has argument count of 0 but internally emits a call with a single argument leading to a mismatch if RecordAfterCall is used. Use
RecordAfterCallHelper instead.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/e763fac3b79275efecc863d93a65c3b3e74e4794

[Vyacheslav Egorov (Google), 2016-12-20 12:56:56]

vegorov@google.com changed reviewers:
+ fschneider@google.com, zra@google.com

[Vyacheslav Egorov (Google), 2016-12-20 12:56:57]

Please take a look. 

This makes all tests pass on simdbc64 + hot-reload.

We still have one failure if I run 

-a simdbc64 --hot-reload --vm-options="--optimization-counter-threshold=10
--no-background-compilation"

I will file a bug for that separately.

[zra, 2016-12-20 15:59:18]

lgtm

[Vyacheslav Egorov (Google), 2016-12-20 16:30:09]

Description was changed from

==========
VM: [DBC] Fix more problems with lazy deopt.

Catch entries must record a lazy deoptimization descriptor because we patch
catch entries if exception reaches a frame that has a pending lazy
deoptimization.

StringInterpolate instruction was recording an incorrect lazy deoptimization
environment - on DBC we drop arguments from it because it is a part of the
return sequence and not a part of the calling sequence like on other
architectures. This means one needs to pass correct argument count down to
RecordAfterCall(Helper). StringInterpolate however has argument count of 0 but
internally emits a call with a single argument leading to a mismatch if
RecordAfterCall is used. Use
RecordAfterCallHelper instead.

BUG=
==========

to

==========
VM: [DBC] Fix more problems with lazy deopt.

Catch entries must record a lazy deoptimization descriptor because we patch
catch entries if exception reaches a frame that has a pending lazy
deoptimization.

StringInterpolate instruction was recording an incorrect lazy deoptimization
environment - on DBC we drop arguments from it because it is a part of the
return sequence and not a part of the calling sequence like on other
architectures. This means one needs to pass correct argument count down to
RecordAfterCall(Helper). StringInterpolate however has argument count of 0 but
internally emits a call with a single argument leading to a mismatch if
RecordAfterCall is used. Use
RecordAfterCallHelper instead.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e763fac3b79275efecc863d93a65c3b3e74e4794
==========

[Vyacheslav Egorov (Google), 2016-12-20 16:30:10]

Committed patchset #1 (id:1) manually as
e763fac3b79275efecc863d93a65c3b3e74e4794 (presubmit successful).

[zra, 2016-12-20 17:25:51]

https://codereview.chromium.org/2595553002/diff/1/tests/language/vm/lazy_deop...
File tests/language/vm/lazy_deopt_vm_test.dart (right):

https://codereview.chromium.org/2595553002/diff/1/tests/language/vm/lazy_deop...
tests/language/vm/lazy_deopt_vm_test.dart:1: // Copyright (c) 2016, the Dart
project authors.  Please see the AUTHORS file
It looks like this test has some Timeouts on the bots.