Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)
Patch Set: Updated cf. comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/resolution.dart
diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart
index 715f1a6adc29d376806b03af63ee773ce761042e..e4d8f2137aa2fe22a757eca77b9b5b53d492538a 100644
--- a/pkg/compiler/lib/src/resolution/resolution.dart
+++ b/pkg/compiler/lib/src/resolution/resolution.dart
@@ -19,7 +19,7 @@ import '../constants/expressions.dart'
ConstructedConstantExpression,
ErroneousConstantExpression;
import '../constants/values.dart' show ConstantValue;
-import '../core_types.dart' show CoreClasses, CoreTypes, CommonElements;
+import '../core_types.dart' show CommonElements;
import '../dart_types.dart';
import '../elements/elements.dart';
import '../elements/modelx.dart'
@@ -72,8 +72,6 @@ class ResolverTask extends CompilerTask {
DiagnosticReporter get reporter => resolution.reporter;
Target get target => resolution.target;
- CoreTypes get coreTypes => resolution.coreTypes;
- CoreClasses get coreClasses => resolution.coreClasses;
CommonElements get commonElements => resolution.commonElements;
ParsingContext get parsingContext => resolution.parsingContext;
CompilerOptions get options => resolution.options;
@@ -146,7 +144,7 @@ class ResolverTask extends CompilerTask {
static void processAsyncMarker(Resolution resolution,
BaseFunctionElementX element, ResolutionRegistry registry) {
DiagnosticReporter reporter = resolution.reporter;
- CoreClasses coreClasses = resolution.coreClasses;
+ CommonElements commonElements = resolution.commonElements;
FunctionExpression functionExpression = element.node;
AsyncModifier asyncModifier = functionExpression.asyncModifier;
if (asyncModifier != null) {
@@ -189,15 +187,15 @@ class ResolverTask extends CompilerTask {
switch (element.asyncMarker) {
case AsyncMarker.ASYNC:
registry.registerFeature(Feature.ASYNC);
- coreClasses.futureClass.ensureResolved(resolution);
+ commonElements.futureClass.ensureResolved(resolution);
break;
case AsyncMarker.ASYNC_STAR:
registry.registerFeature(Feature.ASYNC_STAR);
- coreClasses.streamClass.ensureResolved(resolution);
+ commonElements.streamClass.ensureResolved(resolution);
break;
case AsyncMarker.SYNC_STAR:
registry.registerFeature(Feature.SYNC_STAR);
- coreClasses.iterableClass.ensureResolved(resolution);
+ commonElements.iterableClass.ensureResolved(resolution);
break;
}
}
@@ -539,7 +537,8 @@ class ResolverTask extends CompilerTask {
from, MessageKind.CYCLIC_CLASS_HIERARCHY, {'className': cls.name});
cls.supertypeLoadState = STATE_DONE;
cls.hasIncompleteHierarchy = true;
- cls.allSupertypesAndSelf = coreClasses.objectClass.allSupertypesAndSelf
+ cls.allSupertypesAndSelf = commonElements
+ .objectClass.allSupertypesAndSelf
.extendClass(cls.computeType(resolution));
cls.supertype = cls.allSupertypes.head;
assert(invariant(from, cls.supertype != null,
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698