pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart - Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)

Patch Set: Updated cf. comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

index 68c24516e48eaab2950155ec4a82a6e28158df25..24a66e9a966629723b634b15e5814ec3d3daf22d 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

@@ -129,13 +129,13 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

'enabledJsInterop': backend.jsInteropAnalysis.enabledJsInterop,

'jsInteropBoostrap': backend.jsInteropAnalysis.buildJsInteropBootstrap(),

'isInterceptorClass': namer.operatorIs(backend.helpers.jsInterceptorClass),

- 'isObject': namer.operatorIs(compiler.coreClasses.objectClass),

+ 'isObject': namer.operatorIs(compiler.commonElements.objectClass),

'specProperty': js.string(namer.nativeSpecProperty),

'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),

'hasRetainedMetadata': backend.hasRetainedMetadata,

'types': typesAccess,

- 'objectClassName':

- js.quoteName(namer.runtimeTypeName(compiler.coreClasses.objectClass)),

+ 'objectClassName': js

+ .quoteName(namer.runtimeTypeName(compiler.commonElements.objectClass)),

'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,

'usesMangledNames': compiler.commonElements.mirrorsLibrary != null ||

backend.hasFunctionApplySupport,