pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart - Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)

Patch Set: Updated cf. comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

index 9bdf1468b67292d19c374e59864a1b4569c90431..ad1ef5b292f1299e27215b30f85a298cfa6ef509 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

@@ -162,7 +162,7 @@ class NsmEmitter extends CodeEmitterHelper {

}

// Startup code that loops over the method names and puts handlers on the

// Object class to catch noSuchMethod invocations.

- ClassElement objectClass = compiler.coreClasses.objectClass;

+ ClassElement objectClass = compiler.commonElements.objectClass;

jsAst.Expression createInvocationMirror = backend.emitter

.staticFunctionAccess(backend.helpers.createInvocationMirror);

if (useDiffEncoding) {