net/http/http_network_session.h - Issue 2595413002: Race preconnects to HTTP2 proxies that support alternate proxies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.h

Issue 2595413002: Race preconnects to HTTP2 proxies that support alternate proxies

Patch Set: ps Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_session.h

diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h

index 0987d548b3e1a396416e03a3daf036876b9e53fa..b14b1eb342bfd64fd4352b09d65eb396f022d66a 100644

--- a/net/http/http_network_session.h

+++ b/net/http/http_network_session.h

@@ -207,6 +207,9 @@ class NET_EXPORT HttpNetworkSession

// If true, only one pending preconnect is allowed to proxies that support

// request priorities.

bool restrict_to_one_preconnect_for_proxies;

+ // If true, preconnect jobs to HTTP2 proxies are raced with an alternative

+ // job if the proxy supports an alternative proxy.

+ bool race_preconnects_to_proxies;

Ryan Hamilton 2017/01/23 18:05:53 The comment says this is only for HTTP2 proxies, b

tbansal1 2017/01/23 21:48:22 Done.

Ryan Hamilton 2017/01/24 19:36:59 Hm. Seems like it should work for QUIC proxies too

};

enum SocketPoolType {