- Harden coverage generation, by not attempting to compile

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/code_descriptors.h"
@@ skipping 2020 matching lines @@
   if (function.IsImplicitStaticClosureFunction()) {
     const Instance& closure =
         Instance::ZoneHandle(function.ImplicitStaticClosure());
     ReturnDefinition(new ConstantInstr(closure));
     return;
   }
   if (function.IsNonImplicitClosureFunction()) {
     // The context scope may have already been set by the non-optimizing
     // compiler.  If it was not, set it here.
     if (function.context_scope() == ContextScope::null()) {
-      // TODO(regis): Why are we not doing this in the parser?
       const ContextScope& context_scope = ContextScope::ZoneHandle(
           node->scope()->PreserveOuterScope(owner()->context_level()));
       ASSERT(!function.HasCode());
       ASSERT(function.context_scope() == ContextScope::null());
       function.set_context_scope(context_scope);
+      const Class& cls = Class::Handle(
+          owner()->parsed_function()->function().Owner());
+      // The closure is now properly setup, add it to the lookup table.
+#if DEBUG
+      const Function& found_func = Function::Handle(
+          cls.LookupClosureFunction(function.token_pos()));
+      ASSERT(found_func.IsNull() ||
+             (found_func.token_pos() != function.token_pos()) ||
+             // TODO(hausner): The following check should not be necessary.
+             // Since we only lookup based on the token_pos we can get
+             // duplicate entries due to closurized and non-closurized parent
+             // functions (see Parser::ParseFunctionStatement).
+             // We need two ways to lookup in this cache: One way to cache the
+             // appropriate closure function and one way to find the functions
+             // while debugging (we might need to set breakpoints in multiple
+             // different function for a single token index.)
+             (found_func.parent_function() != function.parent_function()));
+#endif  // DEBUG
+      cls.AddClosureFunction(function);
     }
     ZoneGrowableArray<PushArgumentInstr*>* arguments =
         new ZoneGrowableArray<PushArgumentInstr*>(2);
     ASSERT(function.context_scope() != ContextScope::null());
 
     // The function type of a closure may have type arguments. In that case,
     // pass the type arguments of the instantiator.
     const Class& cls = Class::ZoneHandle(function.signature_class());
     ASSERT(!cls.IsNull());
     const bool requires_type_arguments = cls.HasTypeArguments();
@@ skipping 1751 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart