Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2595363002: Support for Null as bottom in dart2js (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Bill Hesse, floitsch
CC:
reviews_dartlang.org, regis, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -1 line) Patch
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/compiler/dart2js/null_is_bottom_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 2 chunks +28 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/iterable_generate_test.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +18 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/language/null_is_bottom_test.dart View 1 chunk +142 lines, -0 lines 0 comments Download
A tests/language/null_is_bottom_type_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Johnni Winther
4 years ago (2016-12-22 13:17:53 UTC) #3
floitsch
Still LGTM.
4 years ago (2016-12-22 13:57:16 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as f6b5361adb2dc625be17f314b56694330c7b9fe7 (presubmit successful).
4 years ago (2016-12-22 14:02:01 UTC) #6
Bill Hesse
The two added test files are missing newlines at the end of the file.
4 years ago (2016-12-22 15:20:31 UTC) #8
Johnni Winther
On 2016/12/22 15:20:31, Bill Hesse wrote: > The two added test files are missing newlines ...
4 years ago (2016-12-22 15:21:50 UTC) #9
Bill Hesse
4 years ago (2016-12-22 16:04:05 UTC) #10
Message was sent while issue was closed. 
On 2016/12/22 15:21:50, Johnni Winther wrote:
> On 2016/12/22 15:20:31, Bill Hesse wrote:
> > The two added test files are missing newlines at the end of the file.
> 
> Does that have any impact?

No, it just shows up in red when viewing the commit on github, and perhaps in
other editors and file viewers.
It is good to fix it when you can.  Some linters or presubmits may also
complain.

Powered by Google App Engine
This is Rietveld 408576698