chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2595263004: Adding AMP cache PageLoad.* metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2595263004: Adding AMP cache PageLoad.* metrics (Closed)

Patch Set: fixed histogram constants Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index c6d1f3b8300666014980ec6e3c82400e1a4a2027..a88d9a5125b0652080a03e116e1772b267dabc1b 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"

#endif // OS_ANDROID

#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"

@@ -62,6 +63,7 @@ void PageLoadMetricsEmbedder::RegisterObservers(

page_load_metrics::PageLoadTracker* tracker) {

// These classes are owned by the metrics.

tracker->AddObserver(base::MakeUnique<AbortsPageLoadMetricsObserver>());

+ tracker->AddObserver(base::MakeUnique<AMPPageLoadMetricsObserver>());

tracker->AddObserver(base::MakeUnique<CorePageLoadMetricsObserver>());

tracker->AddObserver(

base::MakeUnique<