Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2692)

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Issue 2595263002: Introduce ViewRoot forwarding input/view events to native (Closed)
Patch Set: tests Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
index f263f059d1be0f7349ca2691178ebdb4c3f4797e..3ca2cc602288a7861a81c3d9710c7420832c80b4 100644
--- a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
+++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
@@ -10,6 +10,7 @@ import android.os.Parcelable;
import org.chromium.base.VisibleForTesting;
import org.chromium.ui.OverscrollRefreshHandler;
+import org.chromium.ui.base.ViewRoot;
/**
* The WebContents Java wrapper to allow communicating with the native WebContents object.
@@ -334,6 +335,12 @@ public interface WebContents extends Parcelable {
public void reloadLoFiImages();
/**
+ * Initializes the view hierarchy with {@link ViewRoot} set to the top of the tree.
+ * @param viewRoot The root of the view used to forward input/view events.
+ */
+ public void initViewRoot(ViewRoot viewRoot);
boliu 2017/01/03 19:16:11 I think ViewRoot should be set and stored where Wi
Jinsuk Kim 2017/01/04 10:45:02 Done. It's just that I'm the one who put the comme
boliu 2017/01/04 17:45:10 That's true.. you can move WindowAndroid out of CV
Jinsuk Kim 2017/01/05 11:03:12 I like your suggestion s/WindowAndroid/ViewRoot pa
+
+ /**
* Sends a request to download the given image {@link url}.
* This method delegates the call to the downloadImage() method of native WebContents.
* @param url The URL of the image to download.

Powered by Google App Engine
This is Rietveld 408576698