chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2595263002: Introduce ViewRoot forwarding input/view events to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2595263002: Introduce ViewRoot forwarding input/view events to native (Closed)

Patch Set: rebased & ViewAndroud::Bounds Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java » ('j') | ui/android/view_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 0b1db2bdc2a9b9109d58cd92e81a6cfbad45cde1..8469b7d664a143dc0e843766f0fa4899657ca6d0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -121,7 +121,7 @@ import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.common.Referrer;

import org.chromium.ui.base.DeviceFormFactor;

import org.chromium.ui.base.PageTransition;

-import org.chromium.ui.base.WindowAndroid;

+import org.chromium.ui.base.ViewRoot;

import org.chromium.ui.widget.Toast;

import java.lang.annotation.Retention;

@@ -279,9 +279,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

}

private class TabbedModeTabCreator extends ChromeTabCreator {

- public TabbedModeTabCreator(ChromeActivity activity, WindowAndroid nativeWindow,

+ public TabbedModeTabCreator(ChromeActivity activity, ViewRoot viewRoot,

boolean incognito) {

- super(activity, nativeWindow, incognito);

+ super(activity, viewRoot, incognito);

}

@Override

@@ -1080,8 +1080,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

@Override

protected Pair<TabbedModeTabCreator, TabbedModeTabCreator> createTabCreators() {

return Pair.create(

- new TabbedModeTabCreator(this, getWindowAndroid(), false),

- new TabbedModeTabCreator(this, getWindowAndroid(), true));

+ new TabbedModeTabCreator(this, getViewRoot(), false),

+ new TabbedModeTabCreator(this, getViewRoot(), true));

}

/**