Chromium Code Reviews| Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java |
| diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java |
| index e2f82e34584bb68430d33a6a1396760ae116293b..47e8da6a42962c8a3eef3eec75a690405fc971b2 100644 |
| --- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java |
| +++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java |
| @@ -37,6 +37,7 @@ import org.chromium.content_public.browser.LoadUrlParams; |
| import org.chromium.content_public.browser.NavigationController; |
| import org.chromium.content_public.browser.WebContents; |
| import org.chromium.ui.base.ViewAndroidDelegate; |
| +import org.chromium.ui.base.ViewRoot; |
| import org.chromium.ui.base.WindowAndroid; |
| /** |
| @@ -297,7 +298,7 @@ public class Shell extends LinearLayout { |
| mContentViewCore = new ContentViewCore(context, ""); |
| ContentView cv = ContentView.createContentView(context, mContentViewCore); |
| mContentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv, |
| - webContents, mWindow); |
| + webContents, ViewRoot.create(mWindow)); |
|
boliu
2017/01/05 19:09:28
first question is what calls destroy?
Then after
Jinsuk Kim
2017/01/05 22:30:15
Shouldn't it be created where 'content' is created
boliu
2017/01/05 22:39:38
No, except webview. If it weren't for webview, Vie
|
| mContentViewCore.setActionModeCallback(defaultActionCallback()); |
| mContentViewCore.setContentViewClient(mContentViewClient); |
| mWebContents = mContentViewCore.getWebContents(); |