blimp/client/core/contents/blimp_contents_view_impl_android.cc - Issue 2595263002: Introduce ViewRoot forwarding input/view events to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_view_impl_android.cc

Issue 2595263002: Introduce ViewRoot forwarding input/view events to native (Closed)

Patch Set: updateViewRoot, ... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/blimp_contents_view_impl_android.cc

diff --git a/blimp/client/core/contents/blimp_contents_view_impl_android.cc b/blimp/client/core/contents/blimp_contents_view_impl_android.cc

index 6205fbd40ef86adac9f56d0746360e935977a3cd..93093216dafa3a1e4b15b07fdcc3cb700d010155 100644

--- a/blimp/client/core/contents/blimp_contents_view_impl_android.cc

+++ b/blimp/client/core/contents/blimp_contents_view_impl_android.cc

@@ -32,7 +32,6 @@ BlimpContentsViewImplAndroid::BlimpContentsViewImplAndroid(

view_ = base::MakeUnique<ui::ViewAndroid>();

view_->SetDelegate(blimp_view_->CreateViewAndroidDelegate());

view_->SetLayer(contents_layer);

- blimp_contents->GetNativeWindow()->AddChild(view_.get());

}

BlimpContentsViewImplAndroid::~BlimpContentsViewImplAndroid() = default;