chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 2595263002: Introduce ViewRoot forwarding input/view events to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 2595263002: Introduce ViewRoot forwarding input/view events to native (Closed)

Patch Set: addressed comments Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java » ('j') | content/browser/android/content_view_core_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index 32415fab0ef5c06076b69088fc512097a82e1f13..9da72b74235c3d9a842c46bc09945d7c2ccbd93d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -21,6 +21,7 @@ import org.chromium.content.browser.test.util.DOMUtils;

import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.ActivityWindowAndroid;

import org.chromium.ui.base.ViewAndroidDelegate;

+import org.chromium.ui.base.ViewRoot;

import org.chromium.ui.base.WindowAndroid;

/**

@@ -91,7 +92,7 @@ public class SelectPopupOtherContentViewTest extends ChromeActivityTestCaseBase<

ContentViewCore contentViewCore = new ContentViewCore(getActivity(), "");

ContentView cv = ContentView.createContentView(getActivity(), contentViewCore);

contentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv,

- webContents, windowAndroid);

+ webContents, windowAndroid, ViewRoot.create(windowAndroid));

contentViewCore.destroy();

}

});