Introduce ViewRoot forwarding input/view events to native

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include <stddef.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 37 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/menu_item.h"
 #include "content/public/common/user_agent.h"
 #include "device/geolocation/geolocation_service_context.h"
 #include "jni/ContentViewCore_jni.h"
 #include "jni/DragEvent_jni.h"
 #include "third_party/WebKit/public/platform/WebInputEvent.h"
 #include "ui/android/view_android.h"
+#include "ui/android/view_root.h"
 #include "ui/android/window_android.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/ui_base_switches_util.h"
 #include "ui/events/android/motion_event_android.h"
 #include "ui/events/blink/blink_event_util.h"
 #include "ui/events/blink/web_input_event_traits.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/gesture_detection/motion_event.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/geometry/point_conversions.h"
@@ skipping 199 matching lines @@
   java_ref_.reset();
   if (!j_obj.is_null()) {
     Java_ContentViewCore_onNativeContentViewCoreDestroyed(
         env, j_obj, reinterpret_cast<intptr_t>(this));
   }
 }
 
 void ContentViewCoreImpl::UpdateWindowAndroid(
     JNIEnv* env,
     const base::android::JavaParamRef<jobject>& obj,
+    const base::android::JavaParamRef<jobject>& jview_root,
     jlong window_android) {
-  ui::ViewAndroid* view = GetViewAndroid();
   ui::WindowAndroid* window =

[boliu, 2017/01/04 18:58:06]

should DCHECK that window and view root are either both null or both not null

actually.. perhaps should pass in view_root only since can get the window
android from the view root? Probably should rename the method :)

[Jinsuk Kim, 2017/01/05 11:03:12]

Renamed to UpdateViewRoot.

       reinterpret_cast<ui::WindowAndroid*>(window_android);
   if (window == GetWindowAndroid())

[boliu, 2017/01/04 18:58:05]

this is not enough, what if view_root is different?

[Jinsuk Kim, 2017/01/05 11:03:12]

Used view_root instead. ViewRoot and WA always come in pair now, so this will do
the job.

     return;
+  ui::ViewAndroid* view = GetViewAndroid();
+  view->RemoveFromParent();

[boliu, 2017/01/04 18:58:06]

Remove/AddChild should stay where they used to be

[Jinsuk Kim, 2017/01/05 11:03:12]

Done.

+  ui::ViewRoot::FromJavaObject(env, jview_root)->AddChild(view);

[boliu, 2017/01/04 18:58:05]

probably should match WindowAndroid pattern here too, ie have a getNativePointer
method on the java class

[Jinsuk Kim, 2017/01/05 11:03:12]

Done.

   if (GetWindowAndroid()) {
     for (auto& observer : observer_list_)
       observer.OnDetachedFromWindow();
-    view->RemoveFromParent();
   }
   if (window) {
-    window->AddChild(view);
     for (auto& observer : observer_list_)
       observer.OnAttachedToWindow();
   }
 }
 
 base::android::ScopedJavaLocalRef<jobject>
 ContentViewCoreImpl::GetWebContentsAndroid(JNIEnv* env,
                                            const JavaParamRef<jobject>& obj) {
   return web_contents_->GetJavaWebContents();
 }
@@ skipping 1225 matching lines @@
       static_cast<WebContentsImpl*>(web_contents())->GetView());
   DCHECK(wcva);
   wcva->SetContentViewCore(NULL);
 }
 
 // This is called for each ContentView.
 jlong Init(JNIEnv* env,
            const JavaParamRef<jobject>& obj,
            const JavaParamRef<jobject>& jweb_contents,
            const JavaParamRef<jobject>& jview_android_delegate,
-           jlong jwindow_android,
+           const JavaParamRef<jobject>& jview_root,
            jfloat dipScale,
            const JavaParamRef<jobject>& retained_objects_set) {
   WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(
       WebContents::FromJavaWebContents(jweb_contents));
   CHECK(web_contents) <<
       "A ContentViewCoreImpl should be created with a valid WebContents.";
   ui::ViewAndroid* view_android = web_contents->GetView()->GetNativeView();
   view_android->SetDelegate(jview_android_delegate);
   view_android->SetLayer(cc::Layer::Create());
-
-  ui::WindowAndroid* window_android =
-        reinterpret_cast<ui::WindowAndroid*>(jwindow_android);
-  DCHECK(window_android);
-  window_android->AddChild(view_android);
+  ui::ViewRoot::FromJavaObject(env, jview_root)->AddChild(view_android);
 
   // TODO: pass dipScale.
   ContentViewCoreImpl* view = new ContentViewCoreImpl(
       env, obj, web_contents, dipScale, retained_objects_set);
   return reinterpret_cast<intptr_t>(view);
 }
 
 static ScopedJavaLocalRef<jobject> FromWebContentsAndroid(
     JNIEnv* env,
     const JavaParamRef<jclass>& clazz,
     const JavaParamRef<jobject>& jweb_contents) {
   WebContents* web_contents = WebContents::FromJavaWebContents(jweb_contents);
   if (!web_contents)
     return ScopedJavaLocalRef<jobject>();
 
   ContentViewCore* view = ContentViewCore::FromWebContents(web_contents);
   if (!view)
     return ScopedJavaLocalRef<jobject>();
 
   return view->GetJavaObject();
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content