Remove RenderWidgetHost::GetSnapshotFromRenderer.

Remove RenderWidgetHost::GetSnapshotFromRenderer.

This functionality does not exist on aura or android anymore, and is
going away soon on Mac. RWHViews are always composited now on all
platforms, so the active tab is always able to be copied in the
browser process with CopyFromBackingStore().

This removes the ViewMsg_Snapshot and ViewHostMsg_Snapshot IPCs.

R=piman, thestig
BUG=251966, 251960
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266399

[piman, 2014-04-24 23:17:06]

LGTM, begone.

https://codereview.chromium.org/259523008/diff/1/content/browser/media/captur...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/259523008/diff/1/content/browser/media/captur...
content/browser/media/capture/web_contents_video_capture_device.cc:660:
DidCopyFromBackingStore(
Is reentrancy ok?

[jbauman, 2014-04-24 23:19:06]

Is GetSnapshotFromRenderer only ever used on the active tab?

[danakj, 2014-04-24 23:22:33]

https://codereview.chromium.org/259523008/diff/1/content/browser/media/captur...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/259523008/diff/1/content/browser/media/captur...
content/browser/media/capture/web_contents_video_capture_device.cc:660:
DidCopyFromBackingStore(
On 2014/04/24 23:17:06, piman wrote:
> Is reentrancy ok?

Ya, I believe so. There's no state change in this method except
last_view_size/UMA recording, and nothing happens after.

To make this cleaner I just removed this case, and let CopyFromBackingStore fail
and call the bound fallback with false if it fails.

[danakj, 2014-04-24 23:28:18]

On 2014/04/24 23:19:06, jbauman wrote:
> Is GetSnapshotFromRenderer only ever used on the active tab?

The Snapshot code runs when the tab is hidden, at which time we'll have it
around in the browser.

The extension tab capture code I guess probably can run on any tab if the
extension runs it, but it fails gracefully if the CopyFromBackingStore fails, so
the extension should deal with it (as it must be on aura already).

[danakj, 2014-04-24 23:33:06]

+thestig for chrome/

[danakj, 2014-04-24 23:33:40]

+kenrb for view_messages.h removing IPCs

[Lei Zhang, 2014-04-24 23:50:43]

chrome/ lgtm with possibly more code to delete:

https://codereview.chromium.org/259523008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/capture_web_contents_function.cc (right):

https://codereview.chromium.org/259523008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/capture_web_contents_function.cc:92: WebContents*
contents = GetWebContentsForID(context_id_);
Do you need this anymore? The only reason we looked up |contents| is to use it
below.

[jam, 2014-04-25 05:10:55]

lgtm

[kenrb, 2014-04-25 12:38:58]

lgtm

[danakj, 2014-04-25 15:20:15]

https://codereview.chromium.org/259523008/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/capture_web_contents_function.cc (right):

https://codereview.chromium.org/259523008/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/capture_web_contents_function.cc:92: WebContents*
contents = GetWebContentsForID(context_id_);
On 2014/04/24 23:50:43, Lei Zhang wrote:
> Do you need this anymore? The only reason we looked up |contents| is to use it
> below.

Done.

[danakj, 2014-04-25 15:20:56]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-04-25 18:47:36]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-04-25 18:47:40]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-04-25 19:36:34]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-04-25 19:40:40]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:09:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/259523008/60001

[commit-bot: I haz the power, 2014-04-25 23:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:19:51]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[danakj, 2014-04-25 23:20:15]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:21:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/259523008/60001

[commit-bot: I haz the power, 2014-04-26 00:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:26:13]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[Lei Zhang, 2014-04-26 00:29:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:31:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/259523008/60001

[commit-bot: I haz the power, 2014-04-26 06:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 06:33:59]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[danakj, 2014-04-26 15:43:17]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-26 15:44:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/259523008/60001

[commit-bot: I haz the power, 2014-04-27 00:18:57]

Change committed as 266399