|
|
Created:
6 years, 8 months ago by jonross Modified:
6 years, 7 months ago CC:
chromium-reviews, tfarina, dcheng Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionEnable working tab-dragging tests on Linux
Tab-dragging on linux is mostly working. However the interactive-ui-tests
are all disabled. Enable tab dragging tests that currently work.
Explicitly disable ones that are still broken. These suffer from timing
issues when ran with the X11 windowing system. crbug.com/331924 tracks
these failures as they currently also fail on ChromeOS.
Test=DetachToBrowserTabDragControllerTest
BUG=330429
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267533
Patch Set 1 #Patch Set 2 : Enable Chrome OS Tests #Patch Set 3 : Revert enabled chrome tests #
Messages
Total messages: 30 (0 generated)
Re-enabled tab_drag_controller_interactive_uitest. However I had to disable a series of tests that fail due to timing issues with X11. We do gain 7 working tab tests.
Re-enabled tab_drag_controller_interactive_uitest. However I had to disable a series of tests that fail due to timing issues with X11. We do gain 7 working tab tests.
Great that those now pass. A question: can you please confirm if the tests that are now disabled on Chrome OS (but enabled on Linux Aura) still fail on Chrome OS?
On 2014/04/24 18:56:36, varkha wrote: > Great that those now pass. A question: can you please confirm if the tests that > are now disabled on Chrome OS (but enabled on Linux Aura) still fail on Chrome > OS? Some previously failing Chrome OS tests now pass. This includes some that I've disabled in this patch on Linux. Another 11 tests can be re-enabled for Chrome OS. Would you like them incorporated into this review, or as a follow up patch?
I would enable all the tests that pass both Linux and Chrome OS in this CL and break out the new tests that pass on Chrome OS but not on Linux in a separate CL.
I have enabled Chrome OS tests that are now functioning. Those that pass on Chrome OS but fail on Linux are currently disabled. They will be enabled in a future patch.
Great, lgtm (you will need an OWNER though).
Hi, We are re-enabling some interactive ui tests on linux and chrome os. Work on Aura tab dragging has fixes bugs that affected these tests. Could you provide an OWNER review?
jonross@, heads up. Can you please try and make sure no additional breakage is introduced with https://codereview.chromium.org/254573002/.
lgtm please run tryjobs before landing
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
Linux Chrome OS tests failed on the try servers, though they pass locally. Still appears to be a lack of lock with the x11 event system. Mouse input events go to the event server, which eventually delivers them to the window tree. However the tests can't currently poll this event queue and attempt to check for expected states before the event has been delivered. We will need to work on updating these tests in the future. For now landing the linux only tests.
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
The CQ bit was checked by jonross@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
Message was sent while issue was closed.
Change committed as 267533 |