Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 259513003: Enable working tab-dragging tests on Linux (Closed)

Created:
6 years, 8 months ago by jonross
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable working tab-dragging tests on Linux Tab-dragging on linux is mostly working. However the interactive-ui-tests are all disabled. Enable tab dragging tests that currently work. Explicitly disable ones that are still broken. These suffer from timing issues when ran with the X11 windowing system. crbug.com/331924 tracks these failures as they currently also fail on ChromeOS. Test=DetachToBrowserTabDragControllerTest BUG=330429 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267533

Patch Set 1 #

Patch Set 2 : Enable Chrome OS Tests #

Patch Set 3 : Revert enabled chrome tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 2 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
jonross
Re-enabled tab_drag_controller_interactive_uitest. However I had to disable a series of tests that fail due to ...
6 years, 8 months ago (2014-04-24 17:42:35 UTC) #1
jonross
Re-enabled tab_drag_controller_interactive_uitest. However I had to disable a series of tests that fail due to ...
6 years, 8 months ago (2014-04-24 17:42:37 UTC) #2
varkha
Great that those now pass. A question: can you please confirm if the tests that ...
6 years, 8 months ago (2014-04-24 18:56:36 UTC) #3
jonross
On 2014/04/24 18:56:36, varkha wrote: > Great that those now pass. A question: can you ...
6 years, 8 months ago (2014-04-25 15:22:13 UTC) #4
varkha
I would enable all the tests that pass both Linux and Chrome OS in this ...
6 years, 8 months ago (2014-04-25 15:49:30 UTC) #5
jonross
I have enabled Chrome OS tests that are now functioning. Those that pass on Chrome ...
6 years, 8 months ago (2014-04-25 17:08:48 UTC) #6
varkha
Great, lgtm (you will need an OWNER though).
6 years, 8 months ago (2014-04-25 17:13:40 UTC) #7
jonross
Hi, We are re-enabling some interactive ui tests on linux and chrome os. Work on ...
6 years, 8 months ago (2014-04-25 17:33:37 UTC) #8
varkha
jonross@, heads up. Can you please try and make sure no additional breakage is introduced ...
6 years, 8 months ago (2014-04-25 20:06:37 UTC) #9
jochen (gone - plz use gerrit)
lgtm please run tryjobs before landing
6 years, 7 months ago (2014-04-28 09:29:33 UTC) #10
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-04-29 20:29:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/20001
6 years, 7 months ago (2014-04-29 20:42:45 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:37:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:37:57 UTC) #14
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-04-29 21:40:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/20001
6 years, 7 months ago (2014-04-29 21:41:04 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:21:15 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:21:15 UTC) #18
jonross
Linux Chrome OS tests failed on the try servers, though they pass locally. Still appears ...
6 years, 7 months ago (2014-04-30 22:10:12 UTC) #19
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-04-30 22:10:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
6 years, 7 months ago (2014-04-30 22:11:36 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 22:51:31 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 22:51:32 UTC) #23
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-04-30 23:24:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
6 years, 7 months ago (2014-04-30 23:25:01 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 00:45:22 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 00:45:23 UTC) #27
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 7 months ago (2014-05-01 12:55:38 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/259513003/40001
6 years, 7 months ago (2014-05-01 12:55:46 UTC) #29
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 16:40:45 UTC) #30
Message was sent while issue was closed.
Change committed as 267533

Powered by Google App Engine
This is Rietveld 408576698