Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: third_party/WebKit/Source/platform/heap/WrapperVisitor.h

Issue 2595053002: [wrapper-tracing] Simplify tracing by forbidding tracing from within mixins (Closed)
Patch Set: Guard DCHECK with DCHECK_IS_ON() as the method is only conditionally compiled Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/WrapperVisitor.h
diff --git a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
index 6315aadb89d13c60f56a362c0c240233109df65d..a4fc9770b40bf4d861284984759e290d0c61198d 100644
--- a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
+++ b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
@@ -154,14 +154,6 @@ class PLATFORM_EXPORT WrapperVisitor {
#undef DECLARE_DISPATCH_TRACE_WRAPPERS
- void dispatchTraceWrappers(const void*) const {
- // This call should never be reached as we access all tracing through
- // TraceTraits, which will check that we can dispatch at compile time.
- // This handler is merely here to make adjustAndMarkWrapper compile
- // for GarbageCollectedMixin objects.
- NOTREACHED();
- }
-
virtual bool markWrapperHeader(HeapObjectHeader*) const = 0;
virtual void markWrappersInAllWorlds(const ScriptWrappable*) const = 0;
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698