Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 259503007: Flush microtask before event handlers are invoked (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added an expected.txt file. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8AbstractEventListener.cpp
diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp
index d9b99058814ff9c6dcf7343f6aa549099ac6f7e2..9211d6eb799414f3fba529b7ddca512841fe738d 100644
--- a/Source/bindings/v8/V8AbstractEventListener.cpp
+++ b/Source/bindings/v8/V8AbstractEventListener.cpp
@@ -36,6 +36,7 @@
#include "bindings/v8/V8Binding.h"
#include "bindings/v8/V8EventListenerList.h"
#include "bindings/v8/V8HiddenValue.h"
+#include "core/dom/Microtask.h"
#include "core/events/BeforeUnloadEvent.h"
#include "core/events/Event.h"
#include "core/inspector/InspectorCounters.h"
@@ -109,6 +110,8 @@ void V8AbstractEventListener::invokeEventHandler(ExecutionContext* context, Even
return;
v8::Isolate* isolate = v8Context->GetIsolate();
+ Microtask::performCheckpoint(isolate);
dominicc (has gone to gerrit) 2014/04/25 02:14:50 Can you point to the DOM or HTML spec (...or all s
adamk 2014/04/25 18:23:32 I'm fairly sure this is not specced, and I'm not c
+
v8::Local<v8::Value> returnValue;
{
// Catch exceptions thrown in the event handler so they do not propagate to javascript code that caused the event to fire.

Powered by Google App Engine
This is Rietveld 408576698