LayoutTests/fast/html/imports/import-custom-element-onload.html - Issue 259503007: Flush microtask before event handlers are invoked

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/html/imports/import-custom-element-onload.html

Issue 259503007: Flush microtask before event handlers are invoked (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added an expected.txt file. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/testharness.js"></script>

	5 <script src="../../../resources/testharnessreport.js"></script>

	6 <script>

	7 hello = Object.create(HTMLElement.prototype);

	8 hello.ids = [];

	9 hello.createdCallback = function() {

	10 hello.ids.push(this.id);

	11 };

	12

	13 document.registerElement('x-hello', {prototype: hello});

	14

	15 t = async_test('Custom elements are upgraded when onload is called.');
	dominicc (has gone to gerrit) 2014/04/25 02:14:50 This isn't clear; use "should be" instead of "are" This isn't clear; use "should be" instead of "are" and "when" is vague... before? During? After?
	16

	17 function ready()

	18 {
	dominicc (has gone to gerrit) 2014/04/25 02:14:50 Again, I think this brace goes on the previous lin Again, I think this brace goes on the previous line. JavaScript != C++.
	19 t.step(function() {

	20 assert_array_equals(["1", "2", "3"], hello.ids);
	dominicc (has gone to gerrit) 2014/04/25 02:14:50 Stick to one kind of quote character for string li Stick to one kind of quote character for string literals unless there's a good reason to use a different one.
	21 t.done();

	22 });

	23 }

	24 </script>

	25 <link rel="import" href="resources/import-custom-element-onload-child.html" onlo ad="ready()">

	26 </head>

	27 <body>

	28 </body>

	29 </html>

OLD	NEW