[SyncFS] Refine callback helpers

chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/callback_helper.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace sync_file_system {
 namespace drive_backend {
 
 namespace {
 
 void SimpleCallback(bool* called, int) {
   ASSERT_TRUE(called);
   EXPECT_FALSE(*called);
   *called = true;
 }
 
 void CallbackWithPassed(bool* called, scoped_ptr<int>) {
   ASSERT_TRUE(called);
   EXPECT_FALSE(*called);
   *called = true;
 }
 
 }  // namespace
 
-TEST(DriveBackendCallbackHelperTest, CreateRelayedCallbackTest) {
+TEST(DriveBackendCallbackHelperTest, RelayCallbackTest) {
   base::MessageLoop message_loop;
 
   bool called = false;
-  CreateRelayedCallback(base::Bind(&SimpleCallback, &called)).Run(0);
+  RelayCallbackToTaskRunner(

[peria, 2014/04/24 07:30:05]

callback_helper.h has 2 interface templates, RelayCallbackToTaskRunner() and
RelayCallbackToCurrentThread().
In addition, we can pass 3 types of functions to them, void(), void(T), and
void(T1, T2).

Please make a test set that can detect which template is wrong.
If #40 fails, we cannot detect whether RelayToTaskRunner<void()> has a bug or
RelayCallbackToTaskRunner() has a bug.

[peria, 2014/04/24 07:30:05]

For example, following combination may detect it.
- RelayCallbackToTaskRunner(void()) : (1)
- RelayCallbackToTaskRunner(void(T))
- RelayCallbackToTaskRunner(void(T,U))
- RelayCallbackToCurrentThread(void()) : comparable with (1)

[tzik, 2014/04/24 07:58:34]

I think testing all possible specialization for each simple class is over
pessimistic.

Anyway I change add a .h.pump to generate each pattern of specialization.
I think it's even less error prone now.

+      base::MessageLoopProxy::current(),
+      FROM_HERE,
+      base::Bind(&SimpleCallback, &called, 0)).Run();
   EXPECT_FALSE(called);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(called);
 
   called = false;
-  CreateRelayedCallback(
+  RelayCallbackToCurrentThread(
+      FROM_HERE,
+      base::Bind(&SimpleCallback, &called)).Run(0);
+  EXPECT_FALSE(called);
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(called);
+
+  called = false;
+  RelayCallbackToCurrentThread(
+      FROM_HERE,
       base::Bind(&CallbackWithPassed, &called))
       .Run(scoped_ptr<int>(new int));
   EXPECT_FALSE(called);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(called);
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system