third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 2594883002: DevTools: [Persistence] introduce badged icons instead of checkmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2594883002: DevTools: [Persistence] introduce badged icons instead of checkmarks (Closed)

Patch Set: missing jsdoc Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png ('k') | third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/Icon.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index 4926fac9712de8b707479812097b27abdee2146e..6b4cecc3616a96ad721ee42118986087bb3c9693 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -537,7 +537,7 @@ Components.Linkifier._infoSymbol = Symbol('Linkifier.info');

/**

* @typedef {{

- * icon: ?UI.Icon,

+ * icon: ?Element,

* enableDecorator: boolean,

* uiLocation: ?Workspace.UILocation,

* liveLocation: ?Bindings.LiveLocation,

@@ -581,7 +581,7 @@ Components.LinkDecorator = function() {};

Components.LinkDecorator.prototype = {

/**

* @param {!Workspace.UISourceCode} uiSourceCode

- * @return {?UI.Icon}

+ * @return {?Element}

linkIcon(uiSourceCode) {}

};