third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl - Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations (Closed)

Patch Set: test fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

index 624f450c7b052f687191176dbb5735e88a7fbde6..892a94ef3b932e7f5011e105e705c99d3d157059 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.idl

@@ -706,5 +706,5 @@ typedef unrestricted float GLclampf;

void viewport(GLint x, GLint y, GLsizei width, GLsizei height);

- [RuntimeEnabled=ExperimentalCanvasFeatures, CallWith=ScriptState, RaisesException] void commit();

+ [RuntimeEnabled=ExperimentalCanvasFeatures, CallWith=ScriptState, RaisesException] Promise commit();

};