third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl - Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations (Closed)

Patch Set: test fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h ('K') | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

index 7224955eb2debb96151633a847fd46ad19f3b68b..aa3345c2979be618637a40a9f8f30164ec27f63f 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

@@ -9,9 +9,9 @@

RuntimeEnabled=ExperimentalCanvasFeatures,

] interface OffscreenCanvasRenderingContext2D {

// back-reference to the canvas

- [ImplementedAs=getOffscreenCanvas] readonly attribute OffscreenCanvas canvas;

+ [ImplementedAs=offscreenCanvas] readonly attribute OffscreenCanvas canvas;

- [CallWith=ScriptState, RaisesException] void commit();

+ [CallWith=ScriptState, RaisesException] Promise commit();

// state

void save(); // push state on state stack