Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations (Closed)
Patch Set: test fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
index fa0d239bc05d35536838c8de711742e4014c82a3..05a8c7dcba297b63ec112d18970afad4e4d12c50 100644
--- a/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
+++ b/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
@@ -28,8 +28,11 @@ OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink(
const cc::FrameSinkId& frame_sink_id,
cc::SurfaceManager* surface_manager,
cc::mojom::MojoCompositorFrameSinkClientPtr client)
- : support_(this, surface_manager, frame_sink_id, nullptr, nullptr),
- client_(std::move(client)) {}
+ // TODO(crbug.com/): Pass a valid display so that we can get OnBeginFrame
Stephen White 2016/12/21 15:14:43 Nit: bug ID?
+ // notification to drive
+ : support_(this, surface_manager, frame_sink_id, nullptr /*display*/,
+ nullptr),
+ client_(std::move(client)) {}
OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {}

Powered by Google App Engine
This is Rietveld 408576698