third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp - Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

Issue 2594843002: Implementing promise-based commit for driving OffscreenCanvas animations (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h ('k') | third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

index 999194f6db80ca28d287ec31de44d7a6a28a1e32..2ddfe27b909e4759d15e29fcb0e0e4f3733a9a88 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp

@@ -118,6 +118,10 @@ void CanvasRenderingContext::dispose() {

canvas()->detachContext();

m_canvas = nullptr;

}

+ if (offscreenCanvas()) {

+ offscreenCanvas()->detachContext();

+ m_offscreenCanvas = nullptr;

+ }

}

CanvasRenderingContext::ContextType CanvasRenderingContext::contextTypeFromId(