ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm - Issue 2594793004: Revert 'Bypass UIWebView.scrollView's contentInset implementation with UIScrollView's.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Issue 2594793004: Revert 'Bypass UIWebView.scrollView's contentInset implementation with UIScrollView's. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/fullscreen_controller.h ('K') | « ios/chrome/browser/ui/fullscreen_controller.mm ('k') | ios/web/public/web_state/crw_web_view_scroll_view_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

diff --git a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

index a3f360ffaf8611c7886aa0dbae8b8679c1dcf8e0..d6f3abfb2e0fffaaa94e60e657640b9365eda738 100644

--- a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

+++ b/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

@@ -584,10 +584,7 @@ NSString* const kOverscollActionsDidEnd = @"OverscollActionsDidStop";

}

- (void)setScrollViewContentInset:(UIEdgeInsets)contentInset {

- if (_scrollview)

- [_scrollview setContentInset:contentInset];

- else

- [_webViewScrollViewProxy setContentInsetFast:contentInset];

Eugene But (OOO till 7-30) 2016/12/21 18:48:43 Are you sure that this does not break Pull To Acti

Eugene But (OOO till 7-30) 2016/12/21 19:15:01 Ok. I tested this change and it breaks overscroll.

justincohen 2016/12/21 19:59:45 Done.

+ [_scrollview setContentInset:contentInset];

}

- (UIView<RelaxedBoundsConstraintsHitTestSupport>*)headerView {