Issue 2594733003: Fuchsia: Memory reservation and partial unmapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2594733003: Fuchsia: Memory reservation and partial unmapping (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -39 lines)			Patch
M	runtime/vm/virtual_memory.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/virtual_memory.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/virtual_memory_android.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/virtual_memory_fuchsia.cc	View	1	2 chunks	+68 lines, -33 lines	0 comments	Download
M	runtime/vm/virtual_memory_linux.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/virtual_memory_macos.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/virtual_memory_win.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

zra

Still investigating VirtualMemory::Protect, but this is a good step forward, and we don't have to ...

4 years ago (2016-12-20 23:22:23 UTC) #2

zra

4 years ago (2016-12-21 15:46:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cf631890c6805033c2c09c2c340add98777fdd6c (presubmit successful).