Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
index 80b9848b3e753c9257c3be0efe06d6e9d332f263..cafaa58e4d82a4f4df843fd70bccec460e35550c 100644
--- a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
+++ b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
@@ -149,11 +149,13 @@ void BrowsingDataQuotaHelperImpl::OnGetHostsUsageComplete(
QuotaInfoArray result;
for (auto& pair : *quota_info) {
QuotaInfo& info = pair.second;
+ // TODO? This code skips quota entries without size and hides them this way
msramek 2017/01/09 12:54:43 I see. This is a bug somewhere in StoragePartition
dullweber 2017/01/09 16:05:45 I created https://bugs.chromium.org/p/chromium/iss
+ // but this doesn't fix the issue that there are still quota entries left
+ // behind after deletion.
// Skip unused entries
if (info.temporary_usage <= 0 && info.persistent_usage <= 0 &&
info.syncable_usage <= 0)
msramek 2017/01/09 12:54:43 style nit: I'd prefer keeping the empty line below
dullweber 2017/01/09 16:05:45 Done.
continue;
-
info.host = pair.first;
result.push_back(info);
}

Powered by Google App Engine
This is Rietveld 408576698