Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_utils.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_counter_utils.cc
diff --git a/chrome/browser/browsing_data/browsing_data_counter_utils.cc b/chrome/browser/browsing_data/browsing_data_counter_utils.cc
index c28cceaf1e829e9086bc8a0faf6fdc48feb31ff7..502eaccb3790700bfa34cdaed6bf6ee08ad02d5d 100644
--- a/chrome/browser/browsing_data/browsing_data_counter_utils.cc
+++ b/chrome/browser/browsing_data/browsing_data_counter_utils.cc
@@ -81,6 +81,17 @@ base::string16 GetChromeCounterTextFromResult(
return l10n_util::GetStringUTF16(IDS_DEL_CACHE_COUNTER_ALMOST_EMPTY);
}
+ if (pref_name == browsing_data::prefs::kDeleteCookies) {
+ // Cookie counter.
+ browsing_data::BrowsingDataCounter::ResultInt origin_count =
+ static_cast<const browsing_data::BrowsingDataCounter::FinishedResult*>(
+ result)
+ ->Value();
+ std::ostringstream result;
+ result << origin_count;
+ return base::UTF8ToUTF16(result.str());
msramek 2017/01/09 12:54:43 We should definitely output more than just a numbe
dullweber 2017/01/09 16:05:45 I added the new string from the discussion documen
+ }
+
if (pref_name == browsing_data::prefs::kDeleteMediaLicenses) {
const MediaLicensesCounter::MediaLicenseResult* media_license_result =
static_cast<const MediaLicensesCounter::MediaLicenseResult*>(result);

Powered by Google App Engine
This is Rietveld 408576698