chrome/browser/browsing_data/browsing_data_counter_factory.cc - Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_factory.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)

Patch Set: improve string description Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/browsing_data_counter_factory.cc

diff --git a/chrome/browser/browsing_data/browsing_data_counter_factory.cc b/chrome/browser/browsing_data/browsing_data_counter_factory.cc

index 2cdc16c9955fa1e3c5c9f7c5e3bf87bf5e433544..23b88ff71070e0bd8298334a3f5b95cd13db7fa1 100644

--- a/chrome/browser/browsing_data/browsing_data_counter_factory.cc

+++ b/chrome/browser/browsing_data/browsing_data_counter_factory.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/browsing_data/cache_counter.h"

#include "chrome/browser/browsing_data/downloads_counter.h"

#include "chrome/browser/browsing_data/media_licenses_counter.h"

+#include "chrome/browser/browsing_data/site_data_counter.h"

#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/history/web_history_service_factory.h"

#include "chrome/browser/password_manager/password_store_factory.h"

@@ -60,6 +61,10 @@ BrowsingDataCounterFactory::GetForProfileAndPref(Profile* profile,

pref_name == browsing_data::prefs::kDeleteCacheBasic)

return base::MakeUnique<CacheCounter>(profile);

+ if (pref_name == browsing_data::prefs::kDeleteCookies &&

+ IsCookieCounterEnabled())

+ return base::MakeUnique<SiteDataCounter>(profile);

msramek 2017/03/06 09:40:57 style: braces if the "if" statement takes more tha

dullweber 2017/03/06 10:44:53 Done.

if (pref_name == browsing_data::prefs::kDeletePasswords) {

return base::MakeUnique<browsing_data::PasswordsCounter>(

PasswordStoreFactory::GetForProfile(